Skip to content

add example build with PlatformIO #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

isthaison
Copy link

Add example build with PlatformIO
Board : BOARD_ESP32_S3_LCD_EV_BOARD_V1_5

@isthaison isthaison marked this pull request as draft May 29, 2024 03:16
@isthaison isthaison marked this pull request as ready for review May 29, 2024 03:16
@isthaison
Copy link
Author

@Lzw655 Please check it out

@Lzw655
Copy link
Collaborator

Lzw655 commented May 31, 2024

Sorry, but I'm a bit busy at the moment. I will test it as soon as possible.

@Lzw655
Copy link
Collaborator

Lzw655 commented Jun 4, 2024

Hi @isthaison,

I tested this project and it worked very well. But, to make it more official, there are some suggestions:

  1. Please rebase the commits on the master branch to avoid the conflicting changes caused by the merge from the master branch.
  2. We should remove the large LVGL demo source files, as the "demos" folder contains numerous photos. It would be more beneficial to provide a simple example, such as porting.ino, and include comments to guide users in using LVGL demos.
  3. It's necessary to update the README file. At present, the project is specifically designed for the BOARD_ESP32_S3_LCD_EV_BOARD_V1_5 development board. I recommend using the default ESP_Panel_Board_Supported.h and ESP_Panel_Board_Custom.h, while also providing instructions on how to replace the development board if needed.

It's totally fine if you are unfamiliar with the above process, I can help you with the modifications. Thank you once again for your contribution.

@isthaison
Copy link
Author

I made it simpler

@Lzw655
Copy link
Collaborator

Lzw655 commented Jun 6, 2024

Thank you! I noticed a few errors in the pre-commit stage, so I took your commit and addressed them in pull request #42. Once I'm done with the documentation, I'll proceed to merge it.

@isthaison
Copy link
Author

I get it !!

@isthaison isthaison closed this Jun 6, 2024
Lzw655 pushed a commit that referenced this pull request Jun 14, 2024
Lzw655 added a commit that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants